-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter bank classes #467
Draft
Sara04
wants to merge
32
commits into
NeuroTechX:develop
Choose a base branch
from
Sara04:filter_bank_classes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Filter bank classes #467
Changes from 23 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
a8c1918
n classes not 2
b0a5530
Merge branch 'NeuroTechX:develop' into filter_bank_classes
Sara04 1a4b71b
Remove repeating
b489b90
Merge branch 'filter_bank_classes' of https://github.com/Sara04/moabb…
ec41d89
Update what's new
6fd8c6d
wrong whats new
9639253
Merge branch 'NeuroTechX:develop' into filter_bank_classes
Sara04 cecb1fc
Merge branch 'NeuroTechX:develop' into filter_bank_classes
Sara04 da955e8
Remove Band Pass class
Sara04 a60bbb3
Merge branch 'filter_bank_classes' of https://github.com/Sara04/moabb…
Sara04 022a891
Update is valid method
Sara04 cb07f43
Merge branch 'NeuroTechX:develop' into filter_bank_classes
Sara04 0d226c8
Add docstring inheritance
Sara04 aaaabec
Merge branch 'filter_bank_classes' of https://github.com/Sara04/moabb…
Sara04 698eb79
Merge branch 'NeuroTechX:develop' into filter_bank_classes
Sara04 302fcf6
Merge branch 'NeuroTechX:develop' into filter_bank_classes
Sara04 3391ea4
update filterbank MI
Sara04 314490a
Merge branch 'filter_bank_classes' of https://github.com/Sara04/moabb…
Sara04 5f2c768
First check, after super init
Sara04 c38fad4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 54291e1
Add n classes argument
Sara04 52eace1
Merge branch 'filter_bank_classes' of https://github.com/Sara04/moabb…
Sara04 5f77f33
Merge branch 'develop' into filter_bank_classes
PierreGtch 54487a7
Update moabb/utils.py
Sara04 ca6479b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2c45a05
Update moabb/utils.py
Sara04 36178c5
Update numpy docstring class and change Attributes to Parameters
Sara04 665d3d2
Merge branch 'NeuroTechX:develop' into filter_bank_classes
Sara04 8ac9dd2
Merge branch 'develop' into filter_bank_classes
PierreGtch 55c5db6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9aae7ac
Merge branch 'develop' into filter_bank_classes
PierreGtch 4ee80f1
Merge branch 'develop' into filter_bank_classes
bruAristimunha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,18 +22,18 @@ | |
get_filter_pipeline, | ||
get_resample_pipeline, | ||
) | ||
from moabb.utils import MoabbMetaClass | ||
|
||
|
||
log = logging.getLogger(__name__) | ||
|
||
|
||
class BaseProcessing(metaclass=abc.ABCMeta): | ||
class BaseProcessing(metaclass=MoabbMetaClass): | ||
"""Base Processing. | ||
|
||
Please use one of the child classes | ||
|
||
|
||
Parameters | ||
Attributes | ||
---------- | ||
|
||
filters: list of list (defaults [[7, 35]]) | ||
|
@@ -474,11 +474,11 @@ def _get_events_pipeline(self, dataset): | |
class BaseParadigm(BaseProcessing): | ||
"""Base class for paradigms. | ||
|
||
Parameters | ||
Attributes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
---------- | ||
|
||
events: List of str | None (default None) | ||
event to use for epoching. If None, default to all events defined in | ||
events to use for epoching. If None, default to all events defined in | ||
the dataset. | ||
""" | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you change “Parameters” to “Attributes”?