Implement BaBSR Branching Heuristic as a new Branching Strategy #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of the other way around
|
I think the new option should be documented in the CHANGELOG.md file? |
|
Fixed! |
wu-haoze
requested changes
Jan 9, 2025
…ated related unit tests and references
|
I made the requested changes, and ended up switching to saving bias as a double instead of a Map, updating the unit tests and other references as needed. |
|
I made an optimization to getPreviousBias() where all the NLR iterates over all the constraints the first time getPreviousBias() is called and stores all the previous biases in a map in the NLR. Then whenever getPreviousBias() it pulls the previous bias from the map instead of iterating over all the constraints again. |
wu-haoze
approved these changes
Jan 21, 2025
src/configuration/OptionParser.cpp
Outdated
| @@ -152,7 +152,7 @@ void OptionParser::initialize() | |||
| &( ( *_stringOptions )[Options::SPLITTING_STRATEGY] ) ) | |||
| ->default_value( ( *_stringOptions )[Options::SPLITTING_STRATEGY] ), | |||
| "The branching strategy " | |||
| "(earliest-relu/pseudo-impact/largest-interval/relu-violation/polarity)." | |||
| "(earliest-relu/pseudo-impact/largest-interval/relu-violation/polarity/babsr-heuristic)." | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new branching strategy, the BaBSR branching heuristic. The new change for this new heuristic includes additions to the configuration, option parsing, and engine components.
Key changes include:
Branching Strategy Implementation:
pickSplitPLConstraintBasedOnBaBsrHeuristicmethod in theEngineclass to split on the ReLUs with the highest BaBSR score. [1] [2] [3]ReluConstraintclass, including methods to compute the BaBSR score. [1] [2] [3] [4] [5] [6] [7] [8] [9]Option Parsing:
OptionParserto includebabsras a valid branching strategy.Options::getDivideStrategy()to handle the newbabsr-heuristicstrategy.Testing: