adding signal handler to maraboupy makefile #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
clazarus
commented
May 11, 2018
clazarus
commented
- addded signal handler to maraboupy makefile
- returned PREPROCESSOR_PL_CONSTRAINTS_ADD_AUX_EQUATIONS default value to true (it used to be true and it otherwise slows down runtime of tf and nnet queries that now delegate this functionality to marabou core)
- addded signal handler to maraboupy makefile - returned PREPROCESSOR_PL_CONSTRAINTS_ADD_AUX_EQUATIONS default value to true (it used to be true and it otherwise slows down runtime of tf and nnet queries that now delegate this functionality to marabou core)
|
I didn't get the part about the ADD_AUX_EQUATIONS flags. What did you mean by "delegate this to the marabou core"? Are you seeing speedups when this flag is turned on? |
|
I looked into it and I think I was confused because after we made maraboupy not add this equations explicitly I left this flag on. I will perform some experiments to assess if the speedup it provides (I think it is significant) but I think it makes sense to leave it untouched for now. The only change in this PR is critical for maraboupy to work. |
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* adding signal handler to maraboupy makefile - addded signal handler to maraboupy makefile - returned PREPROCESSOR_PL_CONSTRAINTS_ADD_AUX_EQUATIONS default value to true (it used to be true and it otherwise slows down runtime of tf and nnet queries that now delegate this functionality to marabou core) * leave PREPROCESSOR_PL_CONSTRAINTS_ADD_AUX_EQUATIONS flags untoched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.