-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] expired scipy deprecations, sp.sqrt #616
[Fix] expired scipy deprecations, sp.sqrt #616
Conversation
Hello @Moritz-Alexander-Kern! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-01-25 15:53:34 UTC |
…was introduced with this version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. I confirm that the deprecation warnings and errors related to the new SciPy version are fixed.
dd3146c
into
NeuralEnsemble:master
This pull request (PR) replaces the usage of the
sp.sqrt
function withnp.sqrt
.The deprecation of sp.sqrt expired earlier than expected. Originally, it was planned to be removed with the release of scipy 2.0.0, but with scipy version greater than 1.10.1, unit tests are failing.
Deprecation was introduced in scipy 1.4.0:
https://docs.scipy.org/doc/scipy/release/1.4.0-notes.html#scipy-deprecations
Quote from the scipy release notes:
Support for NumPy functions exposed via the root SciPy namespace is deprecated and will be removed in 2.0.0. For example, if you use scipy.rand or scipy.diag, you should change your code to directly use numpy.random.default_rng or numpy.diag, respectively. They remain available in the currently continuing Scipy 1.x release series.
Further deprecations fixed: