Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Use numpy assert array equal in test_multitaper_cohere_perfect_cohere #573

Merged
merged 10 commits into from
Jul 12, 2023
Merged

[ENH] Use numpy assert array equal in test_multitaper_cohere_perfect_cohere #573

merged 10 commits into from
Jul 12, 2023

Conversation

Moritz-Alexander-Kern
Copy link
Member

@Moritz-Alexander-Kern Moritz-Alexander-Kern commented Jun 5, 2023 •
edited
Loading

This PR is to adress Issue #569

  • use numpy assert_array_equal for unit test
  • skip unit test test_multitaper_cohere_perfect_cohere for numpy==1.25.0
  • issue #24000 on numpy was moved to 1.25.2 milestone

@coveralls
Copy link
Collaborator

coveralls commented Jun 5, 2023 •
edited
Loading

Coverage Status

coverage: 86.97%. remained the same when pulling c012851 on INM-6:enh/MultitaperCoherenceTestCase into 844eb82 on NeuralEnsemble:master.

@Moritz-Alexander-Kern Moritz-Alexander-Kern changed the title [ENH] Use numpy asser array equal in test_multitaper_cohere_perfect_cohere [ENH] Use numpy assert array equal in test_multitaper_cohere_perfect_cohere Jun 6, 2023
@Moritz-Alexander-Kern Moritz-Alexander-Kern added the enhancement Editing an existing module, improving something label Jun 28, 2023
Moritz-Alexander-Kern
Moritz-Alexander-Kern commented Jul 5, 2023
View reviewed changes
Copy link
Member Author

@Moritz-Alexander-Kern Moritz-Alexander-Kern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build wheels

@Moritz-Alexander-Kern Moritz-Alexander-Kern added this to the v0.13.0 milestone Jul 10, 2023
Moritz-Alexander-Kern
Moritz-Alexander-Kern commented Jul 12, 2023
View reviewed changes
Copy link
Member Author

@Moritz-Alexander-Kern Moritz-Alexander-Kern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build wheels

@Moritz-Alexander-Kern Moritz-Alexander-Kern merged commit 4ea3c9a into NeuralEnsemble:master Jul 12, 2023
@Moritz-Alexander-Kern Moritz-Alexander-Kern deleted the enh/MultitaperCoherenceTestCase branch July 21, 2023 12:28
@Moritz-Alexander-Kern Moritz-Alexander-Kern mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Editing an existing module, improving something
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Moritz-Alexander-Kern @coveralls