Multitaper psd segmentation #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re that peak_resolution is the primary parameter.
…tapered_signals should not use signals, but the underlying and modified numpy array Co-authored-by: ackurth <[email protected]>
…er_cross_spectrum test case
…elephant into feature/multitaper_cross_spectrum
Co-authored-by: rjurkus <[email protected]>
…r_cross_spectrum test case (copied from multitaper_cross_spectrum test case)
…ence Co-authored-by: ackurth <[email protected]>
…taper_cross_spectrum Co-authored-by: ackurth <[email protected]>
…er Coherence test case Co-authored-by: ackurth <[email protected]>
Co-authored-by: ackurth <[email protected]>
Fixed several docstring issues (PEP8, unused parameters, wrong parameter names); Fixed the coherence equation string in multitaper_coherence
Co-authored-by: ackurth <[email protected]>
…m' into hotfix/multitaper_psd_segmentation
…sd_segmentation # Conflicts: # elephant/spectral.py # elephant/test/test_spectral.py
Moritz-Alexander-Kern
added
the
enhancement
Moritz-Alexander-Kern
approved these changes
May 25, 2023
| # Average Fourier transform windowed signal | ||
| psd_segment = np.mean(spectrum_estimates, axis=-2) / fs | ||
| # Number of data points in time series | ||
| length_signal = np.shape(data)[1] |
There was a problem hiding this comment.
length_signal not needed at this point? , it is calculated later in _segmented_apply_func ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates
multitaper_psd()with segmentation intosegmented_multitaper_psd()andmultitaper_psd()without segmentation to match the approach used in #525.