Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove pandas bridge #530

Merged

Conversation

Moritz-Alexander-Kern
Copy link
Member

@Moritz-Alexander-Kern Moritz-Alexander-Kern commented Nov 28, 2022

remove pandas_bridge

This PR will remove the pandas_bridge.py module from elephant.

deprecation

The pandas_bridge module was deprecated here: #293 on Mar 2, 2020.

Removal was planned for elephant 0.8.X.

decision

As discussed in the last elephant meeting (Nov 28, 2022), the pandas_bridge module will finally be removed from elephant with release v0.12.0. (v1.0.0 update: 06.11.2023)

@coveralls
Copy link
Collaborator

coveralls commented Nov 28, 2022

Coverage Status

coverage: 87.995% (+0.9%) from 87.137%
when pulling 59a3fee on INM-6:feature/remove_pandas_bridge
into 996e557 on NeuralEnsemble:master.

Copy link
Member Author

@Moritz-Alexander-Kern Moritz-Alexander-Kern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build wheels

@Moritz-Alexander-Kern Moritz-Alexander-Kern removed this from the v0.14.0 milestone Jul 20, 2023
@Moritz-Alexander-Kern Moritz-Alexander-Kern added this to the v1.0.0 milestone Nov 6, 2023
@Moritz-Alexander-Kern Moritz-Alexander-Kern force-pushed the feature/remove_pandas_bridge branch from e4b4520 to 7bcad8e Compare November 6, 2023 14:24
# Conflicts:
#	elephant/pandas_bridge.py
#	elephant/test/test_pandas_bridge.py
Copy link
Member Author

@Moritz-Alexander-Kern Moritz-Alexander-Kern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build wheels

@Moritz-Alexander-Kern
Copy link
Member Author

Moritz-Alexander-Kern commented Nov 8, 2023

Note: The pandas_bridge module was not listed in the elephant.__init__ .

@Moritz-Alexander-Kern Moritz-Alexander-Kern merged commit e867b94 into NeuralEnsemble:master Nov 10, 2023
15 checks passed
@Moritz-Alexander-Kern Moritz-Alexander-Kern deleted the feature/remove_pandas_bridge branch November 13, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants