Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/spike train dissimilarity #482

Merged

Conversation

kloss-o
Copy link
Contributor

@kloss-o kloss-o commented Apr 25, 2022

Added two tests for victor purpura distance.

In Issue #365, a user claims that the results of his own implementation differ from those in elephant.
The new tests compare the results of the VPD in elephant with the original matlab implementation and shows that they are identical.
This used data can be found here in the elephant-data repository.

@pep8speaks
Copy link

pep8speaks commented Apr 25, 2022

Hello @kloss-o! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-25 08:48:19 UTC

@Moritz-Alexander-Kern Moritz-Alexander-Kern added the enhancement Editing an existing module, improving something label Apr 25, 2022
@Moritz-Alexander-Kern Moritz-Alexander-Kern added this to the v0.12.0 milestone Apr 26, 2022
@Moritz-Alexander-Kern Moritz-Alexander-Kern linked an issue Apr 26, 2022 that may be closed by this pull request
@Moritz-Alexander-Kern Moritz-Alexander-Kern merged commit 7034d9b into NeuralEnsemble:master Apr 27, 2022
@Moritz-Alexander-Kern Moritz-Alexander-Kern deleted the fix/SpikeTrainDissimilarity branch June 22, 2022 11:24
Moritz-Alexander-Kern added a commit that referenced this pull request Oct 26, 2022
* bump version number

* bum version number for zenodo

* added release notes to docs

* add Oliver to authors list, see PR  Fix/spike train dissimilarity #482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Editing an existing module, improving something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spike Train Dissimilarity - Question
3 participants