-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added report to coveralls.io to github action runner #480
added report to coveralls.io to github action runner #480
Conversation
… docs html-files as artifact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit confused about the changes regarding mpi4py. Shouldn't we keep tests that do not use mpi?
.github/workflows/CI.yml
Outdated
sudo apt install -y libopenmpi-dev openmpi-bin | ||
pip install coveralls | ||
pip install pytest-cov coveralls | ||
pip install mpi4py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why you include mpi4py tests into this runner -- shouldn't this run without mpi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about this thanks for the reminder.
This was done during development to get coverage on elephant/parallel/mpi.py
.
I suggest to add a coverage report to the MPI runner and revert to non MPI for this runner.
See: 9bdda50
Coveralls
Added coverage report with GitHub actions to coveralls.io/ NeuralEnsemble / elephant
See results: https://coveralls.io/builds/48445138
Since Travis CI was removed, no coverage reports have been pushed to coveralls.io. (last coverage report: 30.03.2022)
Upload docs
The Documentation which is build with GitHub actions is now uploaded as an artifact. (html-files)