Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added report to coveralls.io to github action runner #480

Merged
merged 7 commits into from
Jul 27, 2022

Conversation

Moritz-Alexander-Kern
Copy link
Member

@Moritz-Alexander-Kern Moritz-Alexander-Kern commented Apr 21, 2022

Coveralls

Added coverage report with GitHub actions to coveralls.io/ NeuralEnsemble / elephant

See results: https://coveralls.io/builds/48445138

Since Travis CI was removed, no coverage reports have been pushed to coveralls.io. (last coverage report: 30.03.2022)

Upload docs

The Documentation which is build with GitHub actions is now uploaded as an artifact. (html-files)

@Moritz-Alexander-Kern Moritz-Alexander-Kern marked this pull request as draft April 21, 2022 07:33
@Moritz-Alexander-Kern Moritz-Alexander-Kern marked this pull request as ready for review April 21, 2022 07:58
Copy link
Member

@mdenker mdenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused about the changes regarding mpi4py. Shouldn't we keep tests that do not use mpi?

sudo apt install -y libopenmpi-dev openmpi-bin
pip install coveralls
pip install pytest-cov coveralls
pip install mpi4py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why you include mpi4py tests into this runner -- shouldn't this run without mpi?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about this thanks for the reminder.
This was done during development to get coverage on elephant/parallel/mpi.py.

I suggest to add a coverage report to the MPI runner and revert to non MPI for this runner.

See: 9bdda50

@Moritz-Alexander-Kern Moritz-Alexander-Kern added this to the v0.12.0 milestone Apr 29, 2022
@Moritz-Alexander-Kern Moritz-Alexander-Kern added the enhancement Editing an existing module, improving something label Jul 20, 2022
@mdenker mdenker self-requested a review July 27, 2022 10:14
@Moritz-Alexander-Kern Moritz-Alexander-Kern merged commit 0ffab82 into NeuralEnsemble:master Jul 27, 2022
@Moritz-Alexander-Kern Moritz-Alexander-Kern deleted the fix/add_coveralls branch October 28, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Editing an existing module, improving something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants