disable mac installs for now in setup.py #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Moritz-Alexander-Kern! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-04-14 14:32:27 UTC |
mdenker
requested changes
Apr 14, 2022
setup.py
Outdated
| "version": version, | ||
| "packages": ['elephant', 'elephant.test'], | ||
| "include_package_data": True, | ||
| "ext_modules": [fim_module], |
setup.py
Outdated
| ) | ||
| } | ||
| # do not compile external modules on darwin | ||
| if platform.system() == "Darwin": |
There was a problem hiding this comment.
...and add the extension module here for Windows and Linux platforms.
Moritz-Alexander-Kern
added
build
Moritz-Alexander-Kern
added
the
bug
mdenker
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #469 .
Thanks @heplesser for reporting this.
Bug:
Pip-installing Elephant fails with a compiler error under macOS 12.3.
Fix:
Disable mac installs for now in
setup.py.