-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/elephant data versioning #463
Merged
Moritz-Alexander-Kern
merged 17 commits into
NeuralEnsemble:master
from
INM-6:enh/elephant_data_versioning
Mar 30, 2022
Merged
Enh/elephant data versioning #463
Moritz-Alexander-Kern
merged 17 commits into
NeuralEnsemble:master
from
INM-6:enh/elephant_data_versioning
Mar 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added handling for SSL verification error * update ASSET and UE tutorials
* allow download without verified certificate
Hello @Moritz-Alexander-Kern! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-03-30 15:47:01 UTC |
Moritz-Alexander-Kern
added
the
enhancement
Editing an existing module, improving something
label
Mar 29, 2022
Moritz-Alexander-Kern
added
enhancement
Editing an existing module, improving something
and removed
enhancement
Editing an existing module, improving something
labels
Mar 30, 2022
Moritz-Alexander-Kern
added
enhancement
Editing an existing module, improving something
breaking-changes
and removed
enhancement
Editing an existing module, improving something
labels
Mar 30, 2022
mdenker
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-changes
enhancement
Editing an existing module, improving something
new functionality
New modules, functions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR versioning for elephant-data (currently on: https://gin.g-node.org/INM-6/elephant-data) is introduced.
Issue
Different files from elephant-data are used in unit-tests and tutorial notebooks. Since the datasets on elephant-data may undergo various changes over time, any change would potentially break the unit tests of old elephant versions.
During development of a new tutorial or unit-test the used files might not yet be merged into elephant-data[master]. This requires the use of hard coded links to the development branch (on gin) until merged.
download_datasets
: use only paths relative to repo rootThose issues might be addressed by creating releases of the elephant-data repository. Currently all links used in tutorials and unit-tests have to following structure:
Link to root of repository
+path starting at root
example:
'https://web.gin.g-node.org/INM-6/elephant-data/raw/master/'
+'unittest/spectral/multitaper_psd/data/time_series.npy'
This PR addresses this issue by introducing a new function
download_datasets
, which contains a default URL (first part in example above) and hence only requires the relative path from repository root as input. This default URL could be set to a specific release of elephant-data, e.g.'https://web.gin.g-node.org/INM-6/elephant-data/raw/0.0.1'
pointing to release v0.0.1. With every new version of elephant, this could be changed to the corresponding elephant-data version.Update: A first release of elephant-data was created (v0.11.0).
download_datasets
now uses the currently installed version of elephant to create the URL pointing to a specific elephant-data release.environment variable
ELEPHANT_DATA_URL
Furthermore an environment variable
ELEPHANT_DATA_URL
is introduced, which allows to specify a different URL to the root of the repository.Typical use cases could be development and CI workflows.
- set
ELEPHANT_DATA_URL
to'https://web.gin.g-node.org/INM-6/elephant-data/raw/master/'
- set
ELEPHANT_DATA_URL
to'https://web.gin.g-node.org/INM-6/elephant-data/raw/multitaper'
In both use cases an environment variable is changed and only the relative paths to the repository's root are hard coded.
TODO: