Feature/multitaper psd estimate #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re that peak_resolution is the primary parameter.
…re that peak_resolution is the primary parameter.
…ephant into feature/multitaper_psd_estimate
Co-authored-by: rjurkus <[email protected]>
sym='False' -> sym=False (boolean parameter) nperseg -> n_per_seg (consistency)
…ad data from the elephant-data repo (using test_spike_train_synchrony.py and test_unitary_event_analysis.py approach) Replaced a large part of test_multitaper_psd_against_nitime docstring with a URL to the elephant-data repo, updated the mentioned nitime version and corrected a typo
mdenker
approved these changes
Feb 23, 2022
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix an issue where the authors of #417 where incorrectly identified.
Original PR #417
Revert was done in #457
Description from the original PR #417:
This PR covers the basic implementation of multitaper in Elephant. Tests include a comparison against nitime multitaper. Any feedback is appreciated!
Please note: The test against nitime will fail due to the missing .npy files. Please check if this style of the test is sufficient. If so, the files can be uploaded to the correct location and the test should then pass.