Support SpikeTrainList object and deprecate RecordingChannel in Elephant #447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Neo 0.10.0, there is a new
SpikeTrainList
object. While this new construct behaves like a list, there are a couple of instances where Elephant directly tests if an input is explicitly a list of SpikeTrains. This PR adds support for allowing SpikeTrainList objects as well as lists of SpikeTrains in these circumstances.Fixes:
conversion.BinnedSpiketrain
(wtih regression test, where SpikeTrainLists would lead to incorrect binned matrices)spike_train_synchrony.Synchrotool
classspade
modulestatistics
module,instantaneous_rate()
This PR fixes #431.
Also, in Neo 0.10.0,
RecordingChannelGroup
objects are no longer supported. This affects thecurrent_source_density
, where electrode coordinates where optionally extracted form this object. This PR fixes CSD methods by taking electrode positions from an annotation of the signal. As in the previous version of Elephant, CSD methods alternatively take electrodes as a direct parameter. By nature of the API break in Neo, this also necessarily breaks API in Elephant.