Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary correction rate for firing rate estimator with Gaussian KDE #414

Conversation

pbouss
Copy link
Contributor

@pbouss pbouss commented Apr 12, 2021

No description provided.

@pep8speaks
Copy link

pep8speaks commented Apr 12, 2021

Hello @pbouss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-25 13:50:24 UTC

@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2021

Coverage Status

Coverage increased (+0.03%) to 88.648% when pulling e4c2cef on INM-6:feature/boundary_correction_rate into d0d3920 on NeuralEnsemble:master.

@pbouss pbouss changed the title Coundary correction rate for firing rate estimator with Gaussian KDE Boundary correction rate for firing rate estimator with Gaussian KDE Apr 12, 2021
@mdenker mdenker added bug Indicates an unexpected problem or unintended behavior bugfix Fix for an indentified bug. and removed bug Indicates an unexpected problem or unintended behavior labels May 21, 2021
@mdenker mdenker added this to the v0.11.0 milestone May 21, 2021
@mdenker
Copy link
Member

mdenker commented May 21, 2021

Is this fix related to #374?

@mdenker mdenker self-requested a review June 7, 2021 07:14
@mdenker mdenker self-assigned this Jun 7, 2021
Copy link
Member

@mdenker mdenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for committing this useful addition. I think it would be great to have a bit more documentation on what the border correction is actually doing. With the given information, its very difficult to retrace your thoughts, and in particular, as a researcher one would not really know whether to use the correction or not.

elephant/statistics.py Outdated Show resolved Hide resolved
elephant/test/test_statistics.py Outdated Show resolved Hide resolved
elephant/test/test_statistics.py Outdated Show resolved Hide resolved
elephant/test/test_statistics.py Outdated Show resolved Hide resolved
elephant/statistics.py Show resolved Hide resolved
elephant/statistics.py Outdated Show resolved Hide resolved
elephant/test/test_statistics.py Outdated Show resolved Hide resolved
elephant/test/test_statistics.py Outdated Show resolved Hide resolved
@pbouss
Copy link
Contributor Author

pbouss commented Aug 19, 2021

I still have set old versions of neo and scipy in the requirements.txt. Is this issue solve that did not allow including the newest versions for Travis?

@pbouss pbouss requested a review from mdenker September 21, 2021 13:55
Copy link
Member

@Moritz-Alexander-Kern Moritz-Alexander-Kern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, thanks for contributing.

I have created the following test plot with it:
border_correction
To me the best way to understand this feature is to look at this figure.

elephant/statistics.py Outdated Show resolved Hide resolved
elephant/test/test_statistics.py Show resolved Hide resolved
@pbouss
Copy link
Contributor Author

pbouss commented Jan 28, 2022

Nice feature, thanks for contributing.

I have created the following test plot with it: border_correction To me the best way to understand this feature is to look at this figure.

Thanks, I have various of those figures, also for non-stationary firing rates. And we used this extension already in Stella, Bouss et al. (2021) (bioRxiv and submitted to eneuro).

Co-authored-by: Moritz Kern <[email protected]>
@Moritz-Alexander-Kern Moritz-Alexander-Kern mentioned this pull request Feb 18, 2022
2 tasks
@Moritz-Alexander-Kern Moritz-Alexander-Kern mentioned this pull request Mar 9, 2022
1 task
@Moritz-Alexander-Kern Moritz-Alexander-Kern merged commit 4979f25 into NeuralEnsemble:master Mar 25, 2022
@Moritz-Alexander-Kern Moritz-Alexander-Kern deleted the feature/boundary_correction_rate branch October 28, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix for an indentified bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants