Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bin-Shuffling: reimplemented the continuos time version #397

Merged
merged 18 commits into from
Feb 1, 2021

Conversation

pbouss
Copy link
Contributor

@pbouss pbouss commented Jan 29, 2021

The continuos time version of bin-shuffling preserves now the number of spikes. That is in contrast to how it was done before, where the spike train was first binned to a bool array.

Copy link
Member

@dizcza dizcza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're giving quantites a hard time by throwing all the units you have in a mincer to chew them later on.

A bitter example of your attitude

        surrogate_spiketrain = \
            (surrogate_spiketrain * pq.s).rescale(spiketrain.units)

cries for help.

Instead, quantities require love: do gentle stripping at the entrance, and don't forget to dress them up before you're done.

@pbouss
Copy link
Contributor Author

pbouss commented Jan 29, 2021

You're giving quantites a hard time by throwing all the units you have in a mincer to chew them later on.

A bitter example of your attitude

        surrogate_spiketrain = \
            (surrogate_spiketrain * pq.s).rescale(spiketrain.units)

cries for help.

Instead, quantities require love: do gentle stripping at the entrance, and don't forget to dress them up before you're done.

Yes, sure. I would not consider myself as a friend of quantities. I like to work only on magnitudes, thus fast numpy arrays and only in the very end got back to quantities.
But it actually appears much more natural as you did it now. Thx.

@coveralls
Copy link
Collaborator

coveralls commented Jan 29, 2021

Coverage Status

Coverage decreased (-0.7%) to 89.606% when pulling 1262dab on INM-6:feature/continuous_bin_shuffling into 4a72095 on NeuralEnsemble:master.

@dizcza dizcza merged commit 1ba500a into NeuralEnsemble:master Feb 1, 2021
@dizcza dizcza deleted the feature/continuous_bin_shuffling branch February 1, 2021 10:24
@dizcza dizcza added the enhancement Editing an existing module, improving something label Feb 1, 2021
ackurth pushed a commit to INM-6/elephant that referenced this pull request Oct 1, 2021
…le#397)

Also, fixed trial-shuffling, copy -> deepcopy

Co-authored-by: dizcza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Editing an existing module, improving something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants