fixed bugs in joint-ISI and shuffle ISI #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizcza
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
By the way, the decimals of shuffle_isi can produce bugs, since the units for this are not specified.
Why?decimalsshould be an int, not a quantity - the.roundfunction accepts integers.
There are a few important notes for you about programming that I decided to describe them here. You don't need to worry this time - I fixed them.
elephant/spike_train_surrogates.py
Outdated
| t_start=spiketrain.t_start, | ||
| t_stop=spiketrain.t_stop, | ||
| sampling_rate=spiketrain.sampling_rate) | ||
| ] * n_surrogates |
There was a problem hiding this comment.
[...] * n creates a list of n references to the same object unless the object is a primitive (float or int). Avoid doing so for complex objects. It's always better to create n copies rather than n references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the bugs appearing when preparing the elephant workshop.
First, I spike exactly at t_stop.
Secondly, spike trains with nor properly ordered spikes.
I added the examples originally producing the bugs in the tests.
By the way, the decimals of shuffle_isi can produce bugs, since the units for this are not specified.