Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homogen_poisson_with_refractory_period #292

Merged
merged 13 commits into from
Jan 30, 2020
Merged

Homogen_poisson_with_refractory_period #292

merged 13 commits into from
Jan 30, 2020

Conversation

pbouss
Copy link
Contributor

@pbouss pbouss commented Jan 24, 2020

  • calculates these function now from the ISI-distribution
  • changed other easily seen things.

p-bouss added 3 commits January 24, 2020 16:08
Homogen_poisson_with_refractory_period
90cbc84 
- calculates these function now from the ISI-distribution
- changed other easily seen things.
Changes range of first spike
3320c6e 
- first spike can now start at 0, at not at the refractory period as before
Changed surrogate test according to other changes
9b8c093
@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 84.17% when pulling 237d133 on INM-6:feature/poisson_refr_period into 978763e on NeuralEnsemble:master.

dizcza
dizcza reviewed Jan 24, 2020
View reviewed changes
Copy link
Member

@dizcza dizcza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started typing the comments but then realized it could be many minor things that it'd just easier to fix them together next week.

Cool! You're the first one who started refactoring Elephant according to the new guidelines.

elephant/spike_train_generation.py Outdated Show resolved Hide resolved
elephant/spike_train_generation.py Outdated Show resolved Hide resolved
elephant/spike_train_generation.py Outdated Show resolved Hide resolved
@pep8speaks
Copy link

pep8speaks commented Jan 30, 2020 •
edited
Loading

Hello @pbouss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-30 18:53:53 UTC

@dizcza dizcza merged commit 4e7b332 into NeuralEnsemble:master Jan 30, 2020
@dizcza dizcza deleted the feature/poisson_refr_period branch January 30, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcza dizcza dizcza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbouss @coveralls @pep8speaks @dizcza