Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/oogpfa #287

Merged
merged 38 commits into from
Feb 5, 2020
Merged

Feature/oogpfa #287

merged 38 commits into from
Feb 5, 2020

Conversation

essink
Copy link
Collaborator

@essink essink commented Jan 14, 2020

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jan 14, 2020 •
edited
Loading

Hello @essink! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-02-05 13:10:40 UTC

@coveralls
Copy link
Collaborator

coveralls commented Jan 14, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 84.473% when pulling 8a26d44 on INM-6:feature/oogpfa into 4e7b332 on NeuralEnsemble:master.

dizcza
dizcza reviewed Jan 15, 2020
View reviewed changes
Copy link
Member

@dizcza dizcza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you start changing the documentation, we need to follow these guidelines https://numpydoc.readthedocs.io/en/latest/format.html#overview

Also, Paulina is currently in charge of the correct docstring format. I suggest you sit together with her, while changing GPFA docs.

elephant/gpfa.py Outdated Show resolved Hide resolved
elephant/gpfa.py Outdated Show resolved Hide resolved
elephant/test/test_gpfa.py Outdated Show resolved Hide resolved
essink and others added 19 commits January 15, 2020 11:23
@essink
Remove 'trialId' in seqs object and adapt tests accordingly
bee9905
@essink
Remove trialId from documentation
6b71a95
@essink
Move import to beginning of file
332d6c9
@essink
Rename seqs_train to seqs where it could belong to either train or test
1c69ea9
@essink
Restructure gpfa file locations
af53ed9
@essink
Add explicit test for returned_data option of transform()
710fc33
@essink
Add a first draft of a tutorial notebook
ef77516
@essink
Minor change in documentation
8ae763c
@Junji110
Revise documentation and refactor variable names
041893b
@Junji110
Revise documentation further
45c236c
@Junji110
PEP8ify the codes
a48aac4
@dizcza
import GPFA only if requirements-extras are installed; added __future…
3346e99 
…__ imports
@dizcza
added GPFA reference to doc/modules
20db3e4
@dizcza
import gpfa safely
c1cb242
@dizcza
fixed codefactor
02530f1
@dizcza
fixed conda numpy 1.18.1 breaking change
2ff7c31
@Junji110
Relax the condition for log-likelihood in test_data1() to pass the test
46fe61d
@Junji110
Merge branch 'feature/oogpfa' of github.com:INM-6/elephant into featu…
f8abcc2 
…re/oogpfa
@dizcza
pep8
040f49f
@dizcza dizcza merged commit 596afc3 into NeuralEnsemble:master Feb 5, 2020
@dizcza dizcza deleted the feature/oogpfa branch February 5, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcza dizcza dizcza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@essink @pep8speaks @coveralls @dizcza @Junji110