SPADE: hackathon changes #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # elephant/spade.py
…athon # Conflicts: # elephant/spade.py
…nto feature/spade_hackathon
|
Hello @pbouss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-01-30 13:43:49 UTC |
…nto feature/spade_hackathon
…nto feature/spade_hackathon
rescale quantities outside the loop in concept_output_to_patterns convert fpgrowth_filter to a list comprehension and optimise the order of its tests
…nto feature/spade_hackathon
move duplicated code into external functions simplify and comment unify naming conventions
added more comments and an additional break to improve the performance changed Python2-incompatible parts
Change of AttributeError->ValueError according hint of Danylo Some things for the new style guidelines Comparison of empty lists, sets -> to bool-statements
dizcza
reviewed
Jan 28, 2020
| concepts, rel_matrix = concepts_mining( | ||
| spiketrains, binsize, winlen, min_spikes=min_spikes, | ||
| min_occ=min_occ, max_spikes=max_spikes, max_occ=max_occ, | ||
| min_neu=min_neu, report='a') | ||
| time_mining = time.time() - time_mining | ||
| print("Time for data mining: {}".format(time_mining)) |
There was a problem hiding this comment.
I think it makes sense to put all timings debug info under the verbose flag mode
I'll think how to do this
This reverts commit 159cb2d.
dizcza
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.