Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pairwise_cross_correlation scaleopt flag #277

Merged
merged 4 commits into from
Jan 27, 2020
Merged

pairwise_cross_correlation scaleopt flag #277

merged 4 commits into from
Jan 27, 2020

Conversation

dizcza
Copy link
Member

@dizcza dizcza commented Dec 4, 2019

Fixes #265

  1. Renamed cross_correlation_function() -> pairwise_cross_correlation().
  2. Previously, cross_correlation_function() calculated the unbiased estimate. Now I added the flag scaleopt to be equivalent with matlab xcorr(). Default is ubiased.

@coveralls
Copy link
Collaborator

coveralls commented Dec 4, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 83.375% when pulling 9aa4a3e on INM-6:feature/pairwise_cross_corr into b116804 on NeuralEnsemble:master.

@dizcza dizcza requested a review from mdenker January 20, 2020 09:27
dizcza
dizcza commented Jan 20, 2020
View reviewed changes
Copy link
Member Author

@dizcza dizcza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to think how to rename cross_correlation_function before merging

mdenker
mdenker approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@mdenker mdenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in Elephant meeting, changes are ok, except the new function name, which could also be
cross_correlation
or
cross_correlation_matrix

@mdenker mdenker added the enhancement Editing an existing module, improving something label Jan 20, 2020
@dizcza dizcza mentioned this pull request Jan 20, 2020
Closed
@dizcza dizcza merged commit ca0ff03 into NeuralEnsemble:master Jan 27, 2020
@dizcza dizcza deleted the feature/pairwise_cross_corr branch January 27, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdenker mdenker mdenker approved these changes

Assignees
No one assigned
Labels
enhancement Editing an existing module, improving something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] signal_processing.cross_correlation_function() scaling
3 participants
@dizcza @coveralls @mdenker