Skip to content

Commit

Permalink
Bug fixing for isi function (#104)
Browse files Browse the repository at this point in the history
Bug fix for the isi function: 
* Fixed bug for t_start larger than minimum isi and for non-sorted spiketrains
  • Loading branch information
pietroquaglio authored and alperyeg committed May 16, 2017
1 parent 020af89 commit 9316970
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
8 changes: 5 additions & 3 deletions elephant/statistics.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@ def isi(spiketrain, axis=-1):
"""
if axis is None:
axis = -1
intervals = np.diff(spiketrain, axis=axis)
if hasattr(spiketrain, 'waveforms'):
intervals = pq.Quantity(intervals.magnitude, units=spiketrain.units)
if isinstance(spiketrain, neo.SpikeTrain):
intervals = np.diff(
np.sort(spiketrain.times.view(pq.Quantity)), axis=axis)
else:
intervals = np.diff(np.sort(spiketrain), axis=axis)
return intervals


Expand Down
3 changes: 2 additions & 1 deletion elephant/test/test_statistics.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ def setUp(self):
self.targ_array_1d = self.targ_array_2d_1[0, :]

def test_isi_with_spiketrain(self):
st = neo.SpikeTrain(self.test_array_1d, units='ms', t_stop=10.0)
st = neo.SpikeTrain(
self.test_array_1d, units='ms', t_stop=10.0, t_start=0.29)
target = pq.Quantity(self.targ_array_1d, 'ms')
res = es.isi(st)
assert_array_almost_equal(res, target, decimal=9)
Expand Down

0 comments on commit 9316970

Please sign in to comment.