Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oas): augment auto sampling errors with error location info #114

Merged
merged 4 commits into from
Jan 31, 2022
Merged

feat(oas): augment auto sampling errors with error location info #114

merged 4 commits into from
Jan 31, 2022

Conversation

derevnjuk
Copy link
Member

closes #103

@derevnjuk derevnjuk self-assigned this Jan 27, 2022
@codeclimate
Copy link

codeclimate bot commented Jan 27, 2022 •
edited
Loading

Code Climate has analyzed commit ffaf0c5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 98.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 87.6% (0.1% change).

View more on Code Climate.

@derevnjuk derevnjuk force-pushed the feat_#103/augment_errors_with_error_location_info branch 2 times, most recently from 2a57c40 to 5416db2 Compare January 27, 2022 19:02
@derevnjuk derevnjuk requested a review from pmstss January 28, 2022 11:37
@derevnjuk derevnjuk marked this pull request as ready for review January 28, 2022 11:37
@derevnjuk derevnjuk force-pushed the feat_#103/augment_errors_with_error_location_info branch 2 times, most recently from 5dd3f85 to 3fd7a46 Compare January 28, 2022 12:59
@derevnjuk derevnjuk force-pushed the feat_#103/augment_errors_with_error_location_info branch from 3fd7a46 to cb1b29f Compare January 28, 2022 14:21
pmstss
pmstss reviewed Jan 31, 2022
View reviewed changes
Copy link
Contributor

@pmstss pmstss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍, few minors to consider

packages/oas/src/converter/DefaultConverter.ts Show resolved Hide resolved
packages/oas/src/converter/DefaultConverter.ts Show resolved Hide resolved
packages/oas/src/converter/DefaultConverter.ts Outdated Show resolved Hide resolved
packages/oas/src/converter/DefaultConverter.ts Outdated Show resolved Hide resolved
@derevnjuk derevnjuk mentioned this pull request Jan 31, 2022
Closed
@derevnjuk derevnjuk requested a review from pmstss January 31, 2022 14:35
@derevnjuk derevnjuk merged commit 324d6c6 into master Jan 31, 2022
@derevnjuk derevnjuk deleted the feat_#103/augment_errors_with_error_location_info branch January 31, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmstss pmstss pmstss approved these changes

Assignees

@derevnjuk derevnjuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Augment errors with error location info
2 participants
@derevnjuk @pmstss