Add translations for some NSG sets #763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the language codes in-line with the ISO-639 codes and enables integration with other systems that otherwise use ISO-639 codes (such as jinteki.net).
In order to support Traditional Chinese, we need to differentiate zh-hans and (to be later added) zh-hant.
Add skeleton directories for other languages supported by NSG which don't exist yet: Catalan (ca), Portuguese (pt), Russian (ru), and Traditional Chinese (zh-hant).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a bunch of translated card titles for some NSG sets.
There's a few set-up commits:
Which is then followed up by adding all translated card titles for System Gateway, Midnght Sun, and Parhelion. This is the data I've recieved from NSG so far and other sets should follow in the future.
This supersedes a old pull request which only had a small amount of data (#756).