This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
literalExpressionEvaluator binary operation with boolean changes #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicr99
suggested changes
Jan 26, 2023
src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts
Outdated
Show resolved
Hide resolved
src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts
Outdated
Show resolved
Hide resolved
src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts
Outdated
Show resolved
Hide resolved
src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts
Outdated
Show resolved
Hide resolved
src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts
Outdated
Show resolved
Hide resolved
tests/behaviour/contracts/expressions/literalExpressionEvaluator.sol
Outdated
Show resolved
Hide resolved
src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts
Outdated
Show resolved
Hide resolved
aniket2405
force-pushed
the
literalExpressionEvaluator
branch
from
aba37f1 to
51d89df
Compare
piwonskp
reviewed
Jan 29, 2023
src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts
Outdated
Show resolved
Hide resolved
|
Conflicts need to be resolved |
|
delete the |
…rmindEth/warp into literalExpressionEvaluator
cicr99
reviewed
Jan 30, 2023
tests/behaviour/contracts/expressions/literalExpressionEvaluator.sol
Outdated
Show resolved
Hide resolved
tests/behaviour/contracts/expressions/literalExpressionEvaluator.sol
Outdated
Show resolved
Hide resolved
swapnilraj
reviewed
Feb 2, 2023
src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts
Outdated
Show resolved
Hide resolved
cicr99
suggested changes
Feb 6, 2023
src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts
Outdated
Show resolved
Hide resolved
src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts
Outdated
Show resolved
Hide resolved
change usage of interface to type
cicr99
approved these changes
Mar 1, 2023
rodrigo-pino
approved these changes
Mar 1, 2023
piwonskp
reviewed
Mar 3, 2023
piwonskp
reviewed
Mar 3, 2023
piwonskp
reviewed
Mar 3, 2023
piwonskp
reviewed
Mar 3, 2023
piwonskp
approved these changes
Mar 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #838
The result of the binaryOperation in the
literalExpressionEvaluatorpass expression can be replaced by the left or right expression if thenotNullMemberistrue.