Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Dockerhub latest tag & absolute warplib path #1076

Merged
merged 5 commits into from
May 26, 2023
Merged

Conversation

piwonskp
Copy link
Contributor

There are two ways to retrieve warp root properly:

  • path.dirname(require.main.filename)
  • path.dirname(__dirname)

The difference is __dirname returns the path warp/build while require.main.filename returns warp/bin

Copy link
Contributor

@temyurchenko temyurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched to this branch, built warp and tried running it outside of the directory on some contracts: ERC20, conditionalSimple, freeFunction. Only freeFunction.sol was transpiled successfully, others had import errors. I looked and freeFunction.sol doesn't import anything from warplib, so I guess it's not an indicator.

Can you please give an example that I can run to test this?

@piwonskp
Copy link
Contributor Author

I switched to this branch, built warp and tried running it outside of the directory on some contracts: ERC20, conditionalSimple, freeFunction. Only freeFunction.sol was transpiled successfully, others had import errors. I looked and freeFunction.sol doesn't import anything from warplib, so I guess it's not an indicator.

Can you please give an example that I can run to test this?

Please try again, it should be fixed now

@temyurchenko
Copy link
Contributor

I switched to this branch, built warp and tried running it outside of the directory on some contracts: ERC20, conditionalSimple, freeFunction. Only freeFunction.sol was transpiled successfully, others had import errors. I looked and freeFunction.sol doesn't import anything from warplib, so I guess it's not an indicator.
Can you please give an example that I can run to test this?

Please try again, it should be fixed now

It worked!

@piwonskp piwonskp merged commit c872aa4 into develop May 26, 2023
@piwonskp piwonskp deleted the warplib-absolute-path branch May 26, 2023 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants