Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonce return type #453

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Nonce return type #453

merged 4 commits into from
Oct 30, 2023

Conversation

cicr99
Copy link
Contributor

@cicr99 cicr99 commented Oct 27, 2023

Previously Nonce method was returning a string value but according to the spec it should be returning a felt (see here

Closes #436

@cicr99 cicr99 requested a review from joshklop October 27, 2023 13:17
@cicr99 cicr99 self-assigned this Oct 27, 2023
@cicr99 cicr99 merged commit 322e194 into main Oct 30, 2023
3 checks passed
@cicr99 cicr99 deleted the nonce_return_type branch October 30, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshklop joshklop joshklop approved these changes

Assignees

@cicr99 cicr99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nonce method return type
2 participants
@cicr99 @joshklop