Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Taiko Support on Sedge #487

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

Add Taiko Support on Sedge #487

wants to merge 20 commits into from

Conversation

stdevMac
Copy link
Member

@stdevMac stdevMac commented Dec 6, 2024

Changes:

  • Adds taiko support on Sedge
  • Re-arrange the repo to have a more generic way to add new L2's

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (no functional changes, no api changes)

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 55.05618% with 80 lines in your changes missing coverage. Please review.

Project coverage is 24.87%. Comparing base (a0d5bbb) to head (a3a3e74).

Files with missing lines Patch % Lines
cli/generate.go 37.28% 34 Missing and 3 partials ⚠️
internal/pkg/generate/generate_scripts.go 66.00% 9 Missing and 8 partials ⚠️
internal/pkg/clients/types.go 0.00% 14 Missing ⚠️
cli/sub_gen.go 81.63% 8 Missing and 1 partial ⚠️
internal/pkg/generate/types.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #487      +/-   ##
===========================================
+ Coverage    24.73%   24.87%   +0.13%     
===========================================
  Files          120      120              
  Lines        22299    22435     +136     
===========================================
+ Hits          5515     5580      +65     
- Misses       16239    16302      +63     
- Partials       545      553       +8     
Flag Coverage Δ
unittests 24.87% <55.05%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants