Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change latest flag behavior #483

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Change latest flag behavior #483

wants to merge 5 commits into from

Conversation

stdevMac
Copy link
Member

Changes:

  • Override --latest flag to not use the latest version of the image in the clients if image is specified

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 24.72%. Comparing base (a0d5bbb) to head (9f5d527).

Files with missing lines Patch % Lines
internal/pkg/generate/generate_scripts.go 0.00% 10 Missing and 1 partial ⚠️
cli/generate.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #483      +/-   ##
===========================================
- Coverage    24.73%   24.72%   -0.01%     
===========================================
  Files          120      120              
  Lines        22299    22307       +8     
===========================================
  Hits          5515     5515              
- Misses       16239    16247       +8     
  Partials       545      545              
Flag Coverage Δ
unittests 24.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants