Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monitoring stack e2e tests #481

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Conversation

khalifaa55
Copy link
Contributor

Changes:

  • Add time before checks in monitoring stack e2e tests

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe): testing

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@khalifaa55 khalifaa55 self-assigned this Nov 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.75%. Comparing base (d04b0b4) to head (187b51a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #481   +/-   ##
========================================
  Coverage    24.75%   24.75%           
========================================
  Files          120      120           
  Lines        22299    22299           
========================================
  Hits          5521     5521           
  Misses       16235    16235           
  Partials       543      543           
Flag Coverage Δ
unittests 24.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khalifaa55 khalifaa55 changed the title fix: Increase time in monitoring stack e2e tests fix: monitoring stack e2e tests Nov 15, 2024
@khalifaa55 khalifaa55 force-pushed the fix/monitoring-stack-e2e branch from 131c19d to 913c7fe Compare November 18, 2024 10:27
@khalifaa55 khalifaa55 marked this pull request as ready for review November 18, 2024 11:22
@khalifaa55 khalifaa55 merged commit 0a6ad75 into develop Nov 18, 2024
11 checks passed
@khalifaa55 khalifaa55 deleted the fix/monitoring-stack-e2e branch November 18, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants