Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support mainnet for Lido CSM setup #459

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

khalifaa55
Copy link
Contributor

@khalifaa55 khalifaa55 commented Oct 21, 2024

Changes:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)
Commented test cases that won't work unless mainnet starts having node operators.

@khalifaa55 khalifaa55 self-assigned this Oct 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.61%. Comparing base (4c7e63e) to head (c78411e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #459      +/-   ##
===========================================
+ Coverage    24.59%   24.61%   +0.02%     
===========================================
  Files          119      119              
  Lines        22000    22000              
===========================================
+ Hits          5410     5416       +6     
+ Misses       16062    16058       -4     
+ Partials       528      526       -2     
Flag Coverage Δ
unittests 24.61% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khalifaa55 khalifaa55 merged commit 20eb1bc into develop Oct 23, 2024
8 of 10 checks passed
@khalifaa55 khalifaa55 deleted the feat/support-mainnet-lido branch October 23, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants