Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holesky network #320

Merged
merged 20 commits into from
Oct 16, 2023
Merged

Add holesky network #320

merged 20 commits into from
Oct 16, 2023

Conversation

stdevMac
Copy link
Member

Changes:

  • Add holesky network

Types of changes

  • New feature (non-breaking change which adds functionality)

Testing

Requires testing

  • Yes

In case you checked yes, did you write tests?

  • Yes

@stdevMac stdevMac self-assigned this Oct 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d28c33a) 86.13% compared to head (b18fded) 86.13%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #320   +/-   ##
========================================
  Coverage    86.13%   86.13%           
========================================
  Files           78       78           
  Lines         4557     4558    +1     
========================================
+ Hits          3925     3926    +1     
  Misses         547      547           
  Partials        85       85           
Flag Coverage Δ
unittests 86.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cli/actions/importKeys.go 95.48% <100.00%> (ø)
cli/cli.go 68.75% <100.00%> (ø)
cli/generate.go 90.41% <100.00%> (ø)
cli/keys.go 55.00% <100.00%> (ø)
cli/sub_gen.go 93.83% <100.00%> (+0.02%) ⬆️
configs/init.go 100.00% <ø> (ø)
configs/networks.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
configs/init.go Outdated Show resolved Hide resolved
@AntiD2ta AntiD2ta merged commit 6fc2cdf into develop Oct 16, 2023
@AntiD2ta AntiD2ta deleted the feature/holesky-network branch October 16, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants