Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Network Configs #314

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Update Network Configs #314

merged 4 commits into from
Oct 13, 2023

Conversation

cbermudez97
Copy link
Contributor

@cbermudez97 cbermudez97 commented Sep 26, 2023

Changes:

  • Remove bootnodes from network configs
  • Remove custom configuration for Chiado

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

@cbermudez97 cbermudez97 self-assigned this Sep 26, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3f03977) 86.75% compared to head (58a5f34) 86.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #314      +/-   ##
===========================================
- Coverage    86.75%   86.11%   -0.64%     
===========================================
  Files           78       78              
  Lines         4582     4582              
===========================================
- Hits          3975     3946      -29     
- Misses         522      551      +29     
  Partials        85       85              
Flag Coverage Δ
unittests 86.11% <100.00%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cli/actions/jwt_secrets.go 100.00% <100.00%> (ø)
configs/init.go 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! This requires smoke tests

@AntiD2ta AntiD2ta merged commit d28c33a into develop Oct 13, 2023
@AntiD2ta AntiD2ta deleted the feat/update-networks-configs branch October 13, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants