Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when running Sedge with a non root user #303

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

cbermudez97
Copy link
Contributor

Changes:

  • Fix issue when running Sedge as a non root user.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@cbermudez97 cbermudez97 requested a review from stdevMac July 20, 2023 21:43
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (844072a) 86.69% compared to head (48e5706) 86.80%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
+ Coverage    86.69%   86.80%   +0.10%     
===========================================
  Files           78       78              
  Lines         4578     4614      +36     
===========================================
+ Hits          3969     4005      +36     
  Misses         523      523              
  Partials        86       86              
Flag Coverage Δ
unittests 86.80% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/actions/generation.go 100.00% <100.00%> (ø)
cli/cli.go 67.86% <100.00%> (ø)
cli/generate.go 90.54% <100.00%> (ø)
cli/listClients.go 100.00% <100.00%> (ø)
internal/pkg/clients/clients.go 93.02% <100.00%> (ø)
internal/pkg/clients/types.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening such a nicely done PR very quickly! It seemed you had some fun doing this.

I wonder if these changes affect somehow clients other than Teku. Did you try several combinations?

I made some comments to be solved

}
for _, datadir := range datadirs {
if datadir.createIf {
if _, err := os.Stat(datadir.path); os.IsNotExist(err) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are ignoring err here except when it is an os.IsNotExist. Is this intentional? There could be another type of error related to something else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 1741c7f

cli/actions/generation_test.go Outdated Show resolved Hide resolved
internal/pkg/clients/types.go Outdated Show resolved Hide resolved
internal/pkg/clients/types.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@cbermudez97 cbermudez97 requested a review from AntiD2ta July 25, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants