Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement starknet-rs for contract class endpoints #20

Closed
wants to merge 6 commits into from
Closed

implement starknet-rs for contract class endpoints #20

wants to merge 6 commits into from

Conversation

saimeunt
Copy link
Contributor

@saimeunt saimeunt commented Feb 15, 2024 •
edited
Loading

Implemented class related starknet methods using the starknet-rs package.

Closes #15

@vercel Vercel
Copy link

vercel bot commented Feb 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rpc-request-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 11:23am

@saimeunt saimeunt mentioned this pull request Feb 15, 2024
Closed
@saimeunt
Copy link
Contributor Author

Following up on this PR, added support for trace endpoints.

Closes #17

Also added initial support for crafting an array of transactions.
Fixed some bugs in the params builder (use structuredClone to deep clone objects instead of performing a shallow copy).

@saimeunt
Copy link
Contributor Author

Since most of the work for #16 was already done on this PR I went along and implemented support for write endpoints.

Closes #16

@saimeunt
Copy link
Contributor Author

Following up on the previous work to support starknet-rs, I've implemented call endpoints.

Closes #18

@saimeunt saimeunt mentioned this pull request Feb 20, 2024
Closed
@jelilat
Copy link
Contributor

jelilat commented Feb 20, 2024 •
edited
Loading

Can you please create separate PRs for the issues? It'll make it easier to review.

As stated in the title, the PR should only address #15

@saimeunt

@saimeunt saimeunt closed this Feb 21, 2024
@saimeunt saimeunt reopened this Feb 21, 2024
@saimeunt
Copy link
Contributor Author

@jelilat I've created separate PRs for each commit, they will need to be reviewed in order because they depend on each other.

Closing in favor of #30 #31 #32 #33 #34 #35

@saimeunt saimeunt closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement starknet.rs support for contract class endpoints
2 participants
@saimeunt @jelilat