Build only for Linux x64 on CI #7763
Conversation
src/Nethermind/Nethermind.Taiko.Test/TxPoolContentListsTests.cs
Outdated
Show resolved
Hide resolved
emlautarom1
force-pushed
the
fix/ci-single-platform
branch
from
306267e to
a58d7cb
Compare
| <PropertyGroup Condition="'$(CI)' == 'true'"> | ||
| <!-- Required due to an issue with transitive dependencies of Colorful.Console --> | ||
| <!-- See: https://github.com/tomakita/Colorful.Console/pull/94 --> | ||
| <NoWarn>NU1605</NoWarn> |
There was a problem hiding this comment.
Colorful.Console does not officially support .NET 8 which causes issues when specifying runtimes. I'm not sure if the issue just does not show up in "normal" builds but is still there, or is it only due to the usage of specific runtimes.
Microsoft's docs are quite poor in this case and the proposed workaround just does not work: https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1605#example-3
There was a problem hiding this comment.
Yet another reason to deprecate Nethermind.Cli.
emlautarom1
force-pushed
the
fix/ci-single-platform
branch
from
e8a20a8 to
c3311e5
Compare
|
@rubo how is it that we're no longer facing disk space issues? What did we do to fix this issue? |
There was a problem hiding this comment.
@rubo how is it that we're no longer facing disk space issues? What did we do to fix this issue?
If you wanna see how's that, revert your changes and watch workflows complete successfully. You need the latest master, though. It now purges the disk before starting, hence no storage issues.
| @@ -28,4 +28,4 @@ jobs: | |||
| - name: Set up .NET | |||
| uses: actions/setup-dotnet@v4 | |||
| - name: Build ${{ matrix.solution }}.sln | |||
| run: dotnet build src/Nethermind/${{ matrix.solution }}.sln -c ${{ matrix.config }} | |||
| run: dotnet build src/Nethermind/${{ matrix.solution }}.sln -c ${{ matrix.config }} -p:CI=true | |||
| @@ -32,7 +32,7 @@ jobs: | |||
| uses: actions/setup-dotnet@6bd8b7f7774af54e05809fcc5431931b3eb1ddee #v4.0.1 | |||
| - name: Build Nethermind | |||
| working-directory: src/Nethermind | |||
| run: dotnet build Nethermind.sln -c release | |||
| run: dotnet build Nethermind.sln -c release -p:CI=true | |||
| @@ -81,7 +82,7 @@ jobs: | |||
| - name: ${{ matrix.project }} | |||
| id: test | |||
| run: | | |||
| dotnet test src/Nethermind/${{ matrix.project }} -c release \ | |||
| dotnet test src/Nethermind/${{ matrix.project }} -c release -p:CI=true \ | |||
| @@ -147,7 +149,7 @@ jobs: | |||
| - name: ${{ matrix.project }} | |||
| id: test | |||
| run: | | |||
| dotnet test src/Nethermind/${{ matrix.project }} -c release \ | |||
| dotnet test src/Nethermind/${{ matrix.project }} -c release -p:CI=true \ | |||
| <PropertyGroup Condition="'$(CI)' == 'true'"> | ||
| <!-- Required due to an issue with transitive dependencies of Colorful.Console --> | ||
| <!-- See: https://github.com/tomakita/Colorful.Console/pull/94 --> | ||
| <NoWarn>NU1605</NoWarn> | ||
| <RuntimeIdentifier>linux-x64</RuntimeIdentifier> | ||
| </PropertyGroup> | ||
|
|
|
Closed in favor of #7772. We might want to revisit this approach though given that it should speed up CI time since it generates less artifacts. |
Fixes #7762
Changes
linux-x64on Github WorkflowsTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
Notes on testing
CI should be green without affecting other workflows.
Documentation
Requires documentation update
Requires explanation in Release Notes
Remarks
When running
dotnet buildwe're currently generating native files for platforms that we don't care about liketvos-arm64among several others. All of these files take considerable space which can cause issues due to disk usage on CI.In an ideal world we could list exactly the platforms that we target but alas this does not work (see dotnet/sdk#42153 for an extremely similar case), which limits us to specifying at most one single platform.