Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reorganize runner package #654

Merged
merged 4 commits into from
Sep 9, 2024
Merged

feat: reorganize runner package #654

merged 4 commits into from
Sep 9, 2024

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Sep 5, 2024

This is a proposition to reorganize the runner folder

Until now, we had this separation of Zero / Cairo1 , but actually most of the logic in zero.go (all the checks, endRun etc) is common to both Zero and Cairo.

Feel free to leave comment and share your thoughts about it

@TAdev0 TAdev0 self-assigned this Sep 5, 2024
Copy link
Contributor

@har777 har777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broadly looks fine to me

@TAdev0 TAdev0 merged commit 4d93227 into main Sep 9, 2024
4 checks passed
@TAdev0 TAdev0 deleted the reorganize_runners_folder branch September 9, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants