Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all_cairo layout and add tests for RangeCheck96 #642

Closed
wants to merge 13 commits into from

Conversation

Sh0g0-1758
Copy link
Member

Note: This PR requires #640 to be merged first.

@Sh0g0-1758 Sh0g0-1758 mentioned this pull request Aug 19, 2024
8 tasks
@MaksymMalicki
Copy link
Contributor

MaksymMalicki commented Aug 20, 2024

Hey, I think the all_cairo layout is for development reasons only. It is not included in the LAYOUTS dict here. Do you guys agree?

@Sh0g0-1758
Copy link
Member Author

Sh0g0-1758 commented Aug 22, 2024

mmh it could be. I think (by the description) that probably the layout is just for quick verification of a cairo program.
What do you think @cicr99 ?

@Sh0g0-1758 Sh0g0-1758 marked this pull request as draft August 22, 2024 13:58
@Sh0g0-1758
Copy link
Member Author

Converting this to draft because I think that all_cairo layout will need a couple more functionalities to be implemented.

@TAdev0 TAdev0 marked this pull request as ready for review September 6, 2024 09:02
@Sh0g0-1758
Copy link
Member Author

Closing in favor of #663

@Sh0g0-1758 Sh0g0-1758 closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants