Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl invModPUint512 hint #599

Merged
merged 4 commits into from
Jul 29, 2024
Merged

feat: impl invModPUint512 hint #599

merged 4 commits into from
Jul 29, 2024

Conversation

MartianGreed
Copy link
Contributor

@MartianGreed MartianGreed commented Jul 23, 2024 •
edited by TAdev0
Loading

Resolves #559

@MartianGreed MartianGreed force-pushed the feat/hint-invModPUint512 branch 2 times, most recently from ff2f129 to b347dd8 Compare July 23, 2024 19:30
TAdev0
TAdev0 suggested changes Jul 25, 2024
View reviewed changes
pkg/hintrunner/zero/hintcode.go Outdated Show resolved Hide resolved
pkg/hintrunner/zero/zerohint_uint512.go Outdated Show resolved Hide resolved
pkg/hintrunner/zero/zerohint_uint512.go Outdated Show resolved Hide resolved
@MartianGreed MartianGreed force-pushed the feat/hint-invModPUint512 branch 2 times, most recently from 17e4938 to 71244da Compare July 25, 2024 11:20
@MaksymMalicki
Copy link
Contributor

Hey, could you add this integration test to the integration tests directory and see if it works? Just add the name of the test file to the .env file and run make integration.

@MaksymMalicki
Copy link
Contributor

I also see, that your unit tests are not passing. Please run make unit and resolve all the issues. Try to take the expected values for the tests, by making prints in the hint itself (the code in the link I sent in the previous comment) and running the modified hint with the prints using cairo-compile and cairo-run commands. Thanks!

@MartianGreed
Copy link
Contributor Author

Sure, will do

@MartianGreed
Copy link
Contributor Author

directory

Concerning unit tests, effectively this is not working but since I don't have a math background I tried to solve this by myself but unfortunately didn't succeed. I'm not initiated to modular maths at all...

@MaksymMalicki
Copy link
Contributor

directory

Concerning unit tests, effectively this is not working but since I don't have a math background I tried to solve this by myself but unfortunately didn't succeed. I'm not initiated to modular maths at all...

Hey, no need to know maths in depth, just a couple of prints inside of the hint, compiled and run on python cairo-vm will do the job.

@MartianGreed MartianGreed force-pushed the feat/hint-invModPUint512 branch from e82763a to f1386d6 Compare July 26, 2024 13:12
@MartianGreed MartianGreed marked this pull request as ready for review July 26, 2024 13:12
TAdev0
TAdev0 suggested changes Jul 28, 2024
View reviewed changes
Copy link
Contributor

@TAdev0 TAdev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @MartianGreed ,

great work overall!!!
just left one comment for optimization

pkg/hintrunner/zero/zerohint_uint512.go Outdated Show resolved Hide resolved
@MartianGreed MartianGreed force-pushed the feat/hint-invModPUint512 branch from 46f8fc3 to da13acd Compare July 29, 2024 09:09
@MartianGreed MartianGreed force-pushed the feat/hint-invModPUint512 branch from da13acd to 1f20df9 Compare July 29, 2024 09:19
TAdev0
TAdev0 reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@TAdev0 TAdev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left one comment, otherwise great job !

pkg/hintrunner/zero/zerohint_utils.go Outdated Show resolved Hide resolved
TAdev0
TAdev0 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@TAdev0 TAdev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! great work @MartianGreed

@TAdev0 TAdev0 merged commit 8dc6682 into NethermindEth:main Jul 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaksymMalicki MaksymMalicki MaksymMalicki left review comments

@TAdev0 TAdev0 TAdev0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invModPUint512 hint
3 participants
@MartianGreed @MaksymMalicki @TAdev0