Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated several dependencies. Corrected USAGE.md. Fixed "blink" due to render order when rendering nodes #147

Merged
merged 3 commits into from
Jul 20, 2019

Conversation

aSqrd-eSqrd
Copy link
Contributor

I updated several dependencies. In particular three and tween. I nudged tween.js up trying to get a version that contained a memory usage improvement, but the GIT version tags don't line up with the NPM versions so I'm not sure I actually got the improved memory usage.

I fixed a weird "blink" I had introduced when I added the shape code back in. The "blink" was that for a moment you could see the unlaunched particles and ends of the connection lines inside the node borders before the inner circle and any shape/icon rendered. It was because I was using renderOrder to correct for simply adding the meshes to the node's meshes in the proper order, see nodeViewStandard

WARNING: The following information is NOT an issue with vizceral, vizceral-react, or vizceral-example. It is with @tweenjs/tween.js, but I provide this information so hopefully other users don't lose half a day trying to figure out what broke their vizceral setup.

There is some strange bug in tween that causes either the traffic graphs to not display when you try to drill to a node (occurs with tween NPM v16.8.1 and v16.8.2) and I guess a different bug in tween (NPM) versions 16.9.0 and up. There is some strange prototype or method leak that causes three.js to get just a few of prototypes/methods from tween as attributes on objects. In vizceral, I tried three v0.96.0, v0.98.0, and v0.106.2 and if the tween version was 16.9.0 or higher the prototype/attribute thing happened regardless of the three version, and if the tween was v16.8.1 or v16.8.2 there were no errors or warnings but nothing was displayed when you drilled into a node.... so heads up on this. If you want to see this weird thing just update the @tweenjs/tween.js in vizceral and vizceral-example and after doing the npm link commands so you'll use your local vizceral, vizceral-react, vizceral-example together you just run npm run dev in vizceral-example.

…hat the USAGE.md wouldn't get a crazy title.
…shes as no longer needed. This also eliminates the 'blink' that occured when zooming into a region where the particles and connection line where visible before the node's inner circle mesh was rendered.
…mprovements. WARNING! something buggy in tween versions newer than 16.8.0. I tested and it is not related to updating three.js
@jrsquared jrsquared merged commit 4c48da0 into Netflix:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants