Skip to content
This repository has been archived by the owner on Sep 17, 2021. It is now read-only.

Fix pulling Dart in the nginx Dockerfile #1207

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

mattlorimor
Copy link
Contributor

@mattlorimor mattlorimor commented Jun 13, 2019

Problem

As referenced in #1206, the Docker build is currently broken due to not being able to pull Dart 1.24.* from the package list (it seems to have been removed).

Fix

Pull 1.24.3 of the Dart SDK directly so that the get and build still work.

@mattlorimor
Copy link
Contributor Author

mattlorimor commented Jun 13, 2019

@mikegrima - Per your request ^^^

@mattlorimor
Copy link
Contributor Author

Build fails, but it doesn't appear to be because of this change.

@mikegrima
Copy link
Contributor

hmm look like an issue with moto.

@mikegrima mikegrima merged commit 6fb691c into Netflix:develop Jun 13, 2019
@mattlorimor
Copy link
Contributor Author

mattlorimor commented Jun 14, 2019

@mikegrima

Two of the tests seem to be broken:

  • RDSSubnetGroupWatcherTestCase
  • LambdaFunctionWatcherTestCase

For RDSSubnetGroupWatcherTestCase, I think

subnet = vpc_conn.create_subnet(vpc.id, "10.1.0.0/24")

just needs to change to

subnet = vpc_conn.create_subnet(vpc.id, "10.0.0.0/24")

I can't figure out why len(item_list) is suddenly returning 2 in LambdaFunctionWatcherTestCase, though.

@oba11 oba11 mentioned this pull request Aug 4, 2019
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants