-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Wait for all handled requests to resolve via .flush()
#75
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
41f393a
feat: Wait for all handled requests to resolve via `.flush()`
offirgolan c20a4da
test: Add tests and docs
offirgolan 5fcfc3f
refactor: Move DeferredPromise into core
offirgolan 13331b0
Merge branch 'master' into flush-requests
offirgolan 05e8f58
feat: Add more hooks to support puppeteer adapter
offirgolan 2fffa9a
chore: Cleanup test configs
offirgolan 0bbfd40
fix: Resolve with the request's response
offirgolan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
/** | ||
* Create a deferred promise with `resolve` and `reject` methods. | ||
* | ||
* @returns {Promise} | ||
*/ | ||
export default function DeferredPromise() { | ||
let resolve, reject; | ||
const promise = new Promise((_resolve, _reject) => { | ||
resolve = _resolve; | ||
reject = _reject; | ||
}); | ||
|
||
promise.resolve = resolve; | ||
promise.reject = reject; | ||
|
||
return promise; | ||
} |
23 changes: 23 additions & 0 deletions
23
packages/@pollyjs/utils/tests/unit/utils/deferred-promise-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import DeferredPromise from '../../../src/utils/deferred-promise'; | ||
|
||
describe('Unit | Utils | DeferredPromise', function() { | ||
it('should exist', function() { | ||
expect(DeferredPromise).to.be.a('function'); | ||
expect(DeferredPromise().resolve).to.be.a('function'); | ||
expect(DeferredPromise().reject).to.be.a('function'); | ||
}); | ||
|
||
it('should resolve when calling .resolve()', async function() { | ||
const promise = DeferredPromise(); | ||
|
||
promise.resolve(42); | ||
expect(await promise).to.equal(42); | ||
}); | ||
|
||
it('should reject when calling .reject()', async function() { | ||
const promise = DeferredPromise(); | ||
|
||
promise.reject(new Error('42')); | ||
expect(async () => await promise).to.throw(Error, /42/); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the role of the noops here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the promise can be resolved or rejected, the NOOP just catches both to make sure the Promise.resolve doesnt receive an uncaught promise.