Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Browser (UMD) build now bundles corejs #106

Merged
merged 1 commit into from
Sep 7, 2018
Merged

fix: Browser (UMD) build now bundles corejs #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build-scripts/rollup.browser.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ export default function createBrowserConfig(options = {}, targets) {
plugins: [
alias(lerna()),
json(),
resolve({ browser: true }),
resolve({ browser: true, preferBuiltins: true }),
commonjs(),
babel({
babelrc: false,
runtimeHelpers: true,
exclude: '../../../node_modules/**',
exclude: ['../../../node_modules/**'],
presets: [
[
'@babel/preset-env',
Expand All @@ -37,7 +37,7 @@ export default function createBrowserConfig(options = {}, targets) {
],
plugins: [
'@babel/plugin-external-helpers',
'@babel/plugin-transform-runtime',
['@babel/plugin-transform-runtime', { corejs: 2 }],
['@babel/plugin-proposal-object-rest-spread', { useBuiltIns: true }]
]
}),
Expand Down
6 changes: 3 additions & 3 deletions build-scripts/rollup.node.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@ export default function createNodeConfig(options = {}) {
external,
plugins: [
json(),
resolve(),
resolve({ preferBuiltins: true }),
Copy link
Contributor Author

@jasonmit jasonmit Sep 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is true but by being explicit here it suppresses warnings.

commonjs(),
babel({
babelrc: false,
runtimeHelpers: true,
exclude: '../../../node_modules/**',
exclude: ['../../../node_modules/**'],
presets: [
[
'@babel/preset-env',
{
modules: false,
targets: {
node: 6
node: '6.0.0'
}
}
]
Expand Down
4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"@babel/plugin-transform-runtime": "^7.0.0",
"@babel/preset-env": "^7.0.0",
"@babel/runtime": "^7.0.0",
"@babel/runtime-corejs2": "^7.0.0",
"@commitlint/cli": "^7.0.0",
"@commitlint/config-conventional": "^7.0.1",
"@commitlint/config-lerna-scopes": "^7.0.0",
Expand Down Expand Up @@ -80,8 +81,5 @@
"rollup-plugin-terser": "^2.0.2",
"tap-merge": "^0.3.1",
"testem": "^2.10.0"
},
"dependencies": {
"@babel/runtime-corejs2": "^7.0.0"
}
}