Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor click as dependency for Metaflow #929

Merged
merged 11 commits into from
Feb 3, 2022
Merged

Vendor click as dependency for Metaflow #929

merged 11 commits into from
Feb 3, 2022

Conversation

savingoyal
Copy link
Collaborator

@savingoyal savingoyal commented Jan 25, 2022

Additionally -

  1. Removes coverage and click from Metaflow's pinned dependency requirements for @conda and floats other dependencies.
  2. This PR will result in dependency re-resolution for all workflows that rely on @conda. We can handle it as a special case but the effort/complexity may not be worth it.
    As a side effect this PR now ensures Metaflow @conda works with Py3.9

@savingoyal savingoyal linked an issue Jan 26, 2022 that may be closed by this pull request
@romain-intel
Copy link
Contributor

This LGTM with the following comments:

  • LICENSES need to be included (it's a requirement of the license) for both click and importlib_metadata
  • As discussed, we should roll back importlib_metadata so it supports Py 3.6
  • I wonder if the coverage test in formatter.py should exclude _vendor (is it present)?

@savingoyal
Copy link
Collaborator Author

Added LICENSES for click, importlib_metadata and their dependencies. vendor.py automatically takes care of that - we would need to add more edge cases for LICENSE detection in case we add more dependencies into the mix. Rolled back both click and importlib_metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda decorator cannot resolve
2 participants