Fix issue when running on batch with local metadata #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artifacts were persisted *after* the metadata was saved to S3 to be repatriated locally which caused it to completely miss. This addresses this issue (fixes #878) and also addresses another issue in load_metadata when loading non existent metadata.
oavdeev
reviewed
Jan 14, 2022
| self, contents, allow_overwrite=True, add_attempt=True | ||
| ): | ||
| """ | ||
| Method identical to save_metadata BUT BYPASSES THE CHECK ON DONE |
There was a problem hiding this comment.
Should .save_metadata() call this method then? Or maybe just remove @only_if_done decorator? I'm not 100% sure what scenario is supposed to prevent though, or is it just a sanity check?
Also consider adding a comment explaining what exactly is the "danger" here, I understand that it bypasses that check but what's the actual consequence of this?
There was a problem hiding this comment.
I put some additional comment. Given the length of the method, I rather keep them separate. It is also a little nicer not to call a _dangerous method inside a non dangerous one :).
savingoyal
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifacts were persisted after the metadata was saved to S3 to be
repatriated locally which caused it to completely miss.
This addresses this issue (fixes #878) and also addresses another issue
in load_metadata when loading non existent metadata.