Implementation for Unbounded Foreach #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
changed the title
| self._top_kwargs = {} | ||
| self._step_kwargs = {} | ||
|
|
||
| def _set_step_kwargs(self, kwargs): |
There was a problem hiding this comment.
Is there a reason you didn't just use the setter/getter idiom for this?
| @@ -220,6 +221,7 @@ def step_task_retry_count(self): | |||
| Returns a tuple of (user_code_retries, error_retries). Error retries | |||
| are attempts to run the process after the user code has failed all | |||
| its retries. | |||
| Return None, None to disable all retries by the (native) runtime. | |||
There was a problem hiding this comment.
Rephrase as: Typically, the runtime takes the maximum of retry counts across decorators and user specification to determine the task retry count. If you want to force no retries, return the special values (None, None).
or something similar.
I hadn't understood that from the original comment.
| CondaStepDecorator], ext_plugins.STEP_DECORATORS, 'name') | ||
| CondaStepDecorator, | ||
| InternalUnboundedForeachDecorator], | ||
| ext_plugins.STEP_DECORATORS, 'name') |
| yield '--%s' % k | ||
| if not isinstance(value, bool): | ||
| yield to_unicode(value) | ||
| # def options(mapping): |
| @@ -292,14 +292,13 @@ def dict_to_cli_options(params): | |||
| if k == 'decospecs': | |||
| k = 'with' | |||
| k = k.replace('_', '-') | |||
| if not isinstance(v, tuple): | |||
| v = [v] | |||
| v = v if isinstance(v, list) or isinstance(v, tuple) else [v] | |||
There was a problem hiding this comment.
can replace by isinstance(v, (list, tuple)) instead of both isinstance.
test/core/metaflow_test/cli_check.py
Outdated
| from . import MetaflowCheck, AssertArtifactFailed, AssertLogFailed, truncate | ||
| from . import AssertTagFailed |
There was a problem hiding this comment.
This assertion does not exist.
test/core/metaflow_test/cli_check.py
Outdated
| @@ -18,36 +17,29 @@ class CliCheck(MetaflowCheck): | |||
|
|
|||
| def run_cli(self, args, capture_output=False): | |||
| cmd = [sys.executable, 'test_flow.py'] | |||
| cmd.extend(self.cli_options) | |||
|
|
|||
There was a problem hiding this comment.
is this part of the other diff (#521)?
test/core/tests/timeout_decorator.py
Outdated
| @@ -25,7 +25,7 @@ def check_results(self, flow, checker): | |||
| for step in run: | |||
| for task in step: | |||
| if 'check' in task.data: | |||
| extype = 'metaflow.plugins.timeout_decorators.'\ | |||
| extype = 'metaflow.plugins.timeout_decorator.'\ | |||
|
Replaced by #554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: