Upgrade to Spring Boot 2.1 #825
Conversation
genie-web/src/test/groovy/com/netflix/genie/web/services/impl/DiskJobFileServiceImplSpec.groovy
Outdated
Show resolved
Hide resolved
build.gradle
Outdated
| @@ -91,7 +91,7 @@ configure(javaProjects) { | |||
| dependency("commons-httpclient:commons-httpclient:3.1") | |||
| dependency("commons-io:commons-io:2.6") | |||
| dependency("commons-validator:commons-validator:1.6") | |||
| dependencySet(group: "io.grpc", version: "1.12.0") { | |||
There was a problem hiding this comment.
Is this really necessary? Do we run into some kind of trouble by leaving it higher than recommended?
If i remember correctly, we were getting some very weird concurrency bug that would corrupt the network buffers, it was a known issue, and upgrading to 1.12 fixed it.
There was a problem hiding this comment.
I don't know that it is. You didn't mention that issue yesterday when I asked. It was easier to back down than battle dependency hell internally with the versions but I can remove it and deal with that if there is some functional issue that 1.12 fixed. Since the build passed I didn't think it was an issue. I'll remove this and see if I can resolve the internal versioning.
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
============================================
+ Coverage 88.46% 88.46% +<.01%
Complexity 2958 2958
============================================
Files 361 361
Lines 11855 11856 +1
Branches 790 790
============================================
+ Hits 10488 10489 +1
Misses 1011 1011
Partials 356 356
Continue to review full report at Codecov.
|
Until ajoberstar/gradle-git-publish#65 is fixed
|
@chali Backing Gradle back down here until Gradle Git Publish Issue is addressed |
|
@twicksell FYI in case you have any issues here |
|
@tgianos lgtm 👍 |
Updates to Spring Framework 5.1 transitively and Spring Cloud Greenwich.RELEASE which is the cloud release which supports Boot 2.1