Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend the check on IllegalAttachmentFileNameException #1217

Merged
merged 1 commit into from
May 7, 2024
Merged

Amend the check on IllegalAttachmentFileNameException #1217

merged 1 commit into from
May 7, 2024

Conversation

bhou2
Copy link
Contributor

@bhou2 bhou2 commented May 7, 2024

Revise the check on attachment filename from denying filename.equals("..") to filename.contains("..")

@bhou2 bhou2 requested review from zdong2 and Snetflix May 7, 2024 17:46
Snetflix
Snetflix approved these changes May 7, 2024
View reviewed changes
Copy link

@Snetflix Snetflix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing from filename.equals("..") to filename.contains("..")

@bhou2 bhou2 merged commit 6bad017 into master May 7, 2024
2 checks passed
natedanner pushed a commit to natedanner/Netflix__genie that referenced this pull request May 20, 2024
@bhou2
Amend the check on IllegalAttachmentFileNameException (Netflix#1217)
ec69de7 
Co-authored-by: bhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snetflix Snetflix Snetflix approved these changes

@zdong2 zdong2 Awaiting requested review from zdong2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhou2 @Snetflix