feat(slack): remove signal text from manual mfa engage and add user to channel #5506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several key updates to the manual MFA engagement process and enhances user management within Slack channels. The changes aim to streamline the user engagement workflow and improve the clarity of engagement messages.
Key Changes
Removal of Signal Text from Manual MFA Engagement:
Addition of User to Slack Channel:
Code Refactoring:
handle_engage_user_command
andengage
functions to improve readability and maintainability.Enhanced Error Handling:
Updated Engagement Message Creation:
create_manual_engagement_message
function to ensure engagement messages are clear and contextually relevant.Files Affected
src/dispatch/plugins/dispatch_slack/case/interactive.py
: Major updates to user engagement logic and error handling.src/dispatch/plugins/dispatch_slack/case/messages.py
: Adjustments to message creation functions for better clarity and structure.