Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slack): remove signal text from manual mfa engage and add user to channel #5506

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

whitdog47
Copy link
Contributor

This pull request introduces several key updates to the manual MFA engagement process and enhances user management within Slack channels. The changes aim to streamline the user engagement workflow and improve the clarity of engagement messages.

Key Changes

  1. Removal of Signal Text from Manual MFA Engagement:

    • The signal text has been removed from the manual MFA engagement process to simplify the message structure and focus on essential information.
  2. Addition of User to Slack Channel:

    • Implemented functionality to add users to the relevant Slack channel during the engagement process, ensuring they are part of the conversation and can receive necessary updates.
  3. Code Refactoring:

    • Refactored the handle_engage_user_command and engage functions to improve readability and maintainability.
    • Consolidated duplicate code blocks and optimized the logic for selecting and engaging users.
  4. Enhanced Error Handling:

    • Improved error logging for scenarios where participants or cases are not found, aiding in debugging and system reliability.
  5. Updated Engagement Message Creation:

    • Modified the create_manual_engagement_message function to ensure engagement messages are clear and contextually relevant.
    • Added checks to handle cases where no engagement text is provided, defaulting to a standard message.

Files Affected

  • src/dispatch/plugins/dispatch_slack/case/interactive.py: Major updates to user engagement logic and error handling.
  • src/dispatch/plugins/dispatch_slack/case/messages.py: Adjustments to message creation functions for better clarity and structure.

@whitdog47 whitdog47 added the enhancement New feature or request label Nov 21, 2024
@whitdog47 whitdog47 requested a review from wssheldon November 21, 2024 00:58
@whitdog47 whitdog47 self-assigned this Nov 21, 2024
@whitdog47 whitdog47 changed the title Removing signal text from manual mfa engage and adding user to channel feat(slack): removing signal text from manual mfa engage and adding user to channel Nov 21, 2024
@whitdog47 whitdog47 changed the title feat(slack): removing signal text from manual mfa engage and adding user to channel feat(slack): remove signal text from manual mfa engage and add user to channel Nov 21, 2024
@whitdog47 whitdog47 marked this pull request as ready for review November 21, 2024 02:05
@whitdog47 whitdog47 merged commit 6df78fe into master Nov 22, 2024
8 checks passed
@whitdog47 whitdog47 deleted the enhancement/improving-mfa-challenge branch November 22, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants