Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux(slack): improve case report modal type to assignee and oncall resolution #5197

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

wssheldon
Copy link
Contributor

Problem

Users may accidentally select the incorrect case type when reporting a case. Case types determine who the assignee of a case will be based on the configured on-call schedule for that case type.

Solution

This change improves the user experience of reporting a case in Slack by surfacing who the assignee of a case will be before they report it. Additionally, we provide additional context as 'tips' in the modal to inform the user that they choice they make when selecting a case type does determine backend behavior. Finally, we extend the PagerDuty on-call plugin to support fetching the on-call service URL to further enrich the modal with a hyperlink to on-call schedule that's associated with the case type they selected.

Notes

The backend will continue to function as expected. This is a no-op from a case creation perspective. We simply surface additional context to the user. The logic that determines assignee of a case can be seen below:

    assignee_email = None
    if case_in.assignee:
        # we assign the case to the assignee provided
        assignee_email = case_in.assignee.individual.email
    elif case_type.oncall_service:
        # we assign the case to the oncall person for the given case type
        assignee_email = service_flows.resolve_oncall(
            service=case_type.oncall_service, db_session=db_session
        )
    elif current_user:
        # we fall back to assign the case to the current user
        assignee_email = current_user.email

Screencast

case_type_modal.mp4

@wssheldon wssheldon added the enhancement New feature or request label Sep 12, 2024
@wssheldon wssheldon self-assigned this Sep 12, 2024
@wssheldon
Copy link
Contributor Author

Note, I believe the override may not be working as expected -- digging in on that.

@wssheldon
Copy link
Contributor Author

Note, I believe the override may not be working as expected -- digging in on that.

Fixed in 5c377c1

@wssheldon wssheldon merged commit 07b5396 into master Sep 16, 2024
8 checks passed
@wssheldon wssheldon deleted the ux/slack-case-report branch September 16, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants