Validate IncidentUpdate's incident_type field against the retrieved incident type. #4699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IncidentUpdate's
incident_type
field is an IncidentTypeBase, which does not have anid
field. Thus, the initialid
comparison resulted in an error.However, earlier in the
incident_service.update()
function call, theincident_type
is already retrieved. We can perform the comparisons against this object'sid
.